search

ExocoreNetwork / exocore-contracts

5 stars 5 forks source link

update executor options for solana client controller #120

Closed magj2006 closed 2 weeks ago

magj2006 commented 2 weeks ago

update for #119 : add definition of Solana devnet & mainnet ChinaID set unordered options when sending message to Solana Chain set value when calling addWhitelistToken to add token on Solana Chain

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes in this pull request focus on enhancing the response handling and messaging logic within the ExocoreGateway and ExocoreGatewayStorage contracts. Modifications include updates to several functions to include additional data in responses for specific source chain IDs related to Solana. New constants for Solana's mainnet and devnet chain IDs, along with a messaging value, have been introduced. Function signatures have also been updated to reflect these changes, ensuring improved interchain communication.

Changes

File Change Summary
src/core/ExocoreGateway.sol Updated response handling in handleLSTTransfer, handleNSTTransfer, and handleRewardOperation to include token and staker data. Altered _sendInterchainMsg and quote functions to conditionally set options based on source chain ID and action type. Function signatures modified to include public onlyCalledFromThis and internal whenNotPaused modifiers.
src/storage/ExocoreGatewayStorage.sol Added constants for Solana blockchain: SOLANA_MAINNET_CHAIN_ID, SOLANA_DEVNET_CHAIN_ID, and SOLANA_WHITELIST_TOKEN_MSG_VALUE. Introduced _isSolana function to check if a chain ID corresponds to Solana. No changes to existing logic or control flow.
test/foundry/unit/ExocoreGateway.t.sol Enhanced test suite for Solana client chain support, added new variables, overloaded generateUID, and introduced test_Success_AddWhiteListTokenOnSolana function. Updated RegisterOrUpdateClientChain for Solana client chain handling.

Possibly related PRs

Suggested reviewers

Poem

🐰 In the realm of chains where tokens flow,
New constants gleam, like stars aglow.
Responses richer, with data to share,
In the world of Solana, we leap without care.
With each transfer, a hop and a cheer,
Our gateway's magic brings us near! ✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between 6cb76220dd99fe2e3cde65749cb8bdf4fa3a3bc3 and f5fbb8650983534ca1219429c08e2fed672ad864.
📒 Files selected for processing (1) * src/core/ExocoreGateway.sol (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * src/core/ExocoreGateway.sol

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 2 weeks ago

Linting failed. Please check the logs.

github-actions[bot] commented 2 weeks ago

The build has failed. Please check the logs.

magj2006 commented 2 weeks ago

Please make similar edits in ExocoreGatewayMock.sol and add unit tests to verify the event emission in ExocoreGateway.t.sol

Added, please review again.