ExocoreNetwork / exocore

Omnichain Restaking
7 stars 9 forks source link

chore(lint): Fix super linter (again) #14

Closed MaxMustermann2 closed 6 months ago

MaxMustermann2 commented 6 months ago

The super linter workflow is running differently between a branch push and a pull request. As a consequence, we see a failure on the branch here when a run on the corresponding pull request passed. This change attempts to fix the issue.

MaxMustermann2 commented 6 months ago

On the develop branch, these Lint items were run.

BASH
BASH_EXEC
DOCKERFILE_HADOLINT
GITHUB_ACTIONS
GITLEAKS
JSON
MARKDOWN
PROTOBUF
SHELL_SHFMT
YAML

Of these, the failures are BASH, DOCKERFILE_HADOLINT, GITLEAKS, MARKDOWN, SHELL_SHFMT, YAML.

On this pull request, the items that run are as follows.

BASH
BASH_EXEC
CHECKOV
DOCKERFILE_HADOLINT
GITHUB_ACTIONS
GITLEAKS
MARKDOWN
PROTOBUF
SHELL_SHFMT
YAML

All of these passed, including the ones that previously failed on develop.

Note that the JSON check is not run within this PR, but it was run on develop. It is because this PR disables the JSON check since we don't have any non-generated JSON files beyond the lint configuration.

The PR adds back the IaC (Infrastructure as Code) check and ensures it passes and skips generated files.

JSON CHECKOV
develop :white_check_mark: :x: (skipped)
this PR :x: (skipped)
MaxMustermann2 commented 6 months ago

Files which have noteworthy changes to review: