search

ExocoreNetwork / exocore

Omnichain Restaking
7 stars 9 forks source link

feat(oracle): replace signer with consensuskey and use ed25519 to sign the message #67

Closed leonz789 closed 3 months ago

leonz789 commented 4 months ago

Description

Use consensuskey as signing key to sign create-price message, and add corresponding support for ed25519. This PR need to work with PR #63 . It should be merged after PR #63

Changes

Notable changes:

Closes #XXX

Summary by CodeRabbit

leonz789 commented 4 months ago

The Lint Code Base error report is for simulation, could be ignored

coderabbitai[bot] commented 3 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

This update primarily enhances the Cosmos SDK's transaction processing by improving signature verification, gas consumption, and sequence handling. Notable changes include switching from the staking to the dogfood module in the context of Exocore validators, updating package versions, and refining the validation mechanics for Oracle price transactions. These changes are aimed at boosting efficiency and robustness in transaction verification processes.

Changes

Files Change Summaries
app/ante/cosmos/sigverify.go Introduced signature verification functionality, gas consumption logic, and simulation setup for signatures.
app/ante/handler_options.go Switched decorators to use cosmosante package for signature handling in newCosmosAnteHandler.
go.mod Updated various package versions including cosmossdk.io/errors, cosmossdk.io/math, github.com/cometbft/cometbft, github.com/cosmos/cosmos-sdk, and others.
local_node.sh Added a sed command to replace enable = false with enable = true in a specific file.
testutil/keeper/oracle.go Replaced stakingKeeper.Keeper{} with dogfoodkeeper.Keeper{} in the OracleKeeper function.
x/oracle/keeper/common/expected_keepers.go Renamed KeeperStaking to KeeperDogfood and added methods related to dogfood types.
x/oracle/keeper/keeper.go Refactored references from KeeperStaking to KeeperDogfood within the Keeper struct and the NewKeeper function.
x/oracle/keeper/msg_server_create_price_test.go Updated imports, method references, and field types from staking to dogfood module in the price creation tests.
x/oracle/keeper/single.go Refactored validator power retrieval from staking module to dogfood module in recacheAggregatorContext and initAggregatorContext.
x/oracle/types/message_create_price.go Switched from sdk.ValAddressFromBech32 to sdk.AccAddressFromBech32 for creator validation in MsgCreatePrice.
x/oracle/types/message_create_price_test.go Updated Creator field type in TestMsgCreatePrice_ValidateBasic from ValAddress to AccAddress.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CosmosSDK
    participant DogfoodModule
    participant GasMeter

    Client->>CosmosSDK: Submit Transaction
    CosmosSDK->>DogfoodModule: Validate Signatures
    DogfoodModule-->>CosmosSDK: Validation Result
    CosmosSDK->>GasMeter: Consume Gas
    GasMeter-->>CosmosSDK: Gas Consumption
    CosmosSDK->>Client: Transaction Result

Poem

In the Cosmos, valves rotate,
Validator keys, they resonate.
Dogfood modules take the flame,
Gas is burned in code’s grand game.
With signatures now verified,
Transactions flow, no need to hide.
In this upgrade, success resides! 🚀🐇🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloud8little commented 3 months ago

@leonz789 could you fix the lint error?

cloud8little commented 3 months ago

Test passed.