search

ExocoreNetwork / exocore

Omnichain Restaking
7 stars 9 forks source link

fix(oracle): use timestamp of message to set final price #74

Closed leonz789 closed 2 months ago

leonz789 commented 4 months ago

Description

Set timestamp of final price with the timestamp from message

Closes #XXX

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate limit exceeded

@leonz789 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 56 minutes and 2 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between fe204f0ccb40927d7e069d556b8db3f7fc22f482 and 97d55a8bcfb8575242f44d8e9e7a78e04909535a.

Walkthrough

These changes primarily focus on enhancing timestamp handling and validation across different modules in the x/oracle keeper. The updates ensure timestamps are sourced correctly, validated properly, and incorporated neatly within tests and error handling, thereby improving data consistency and reducing potential errors associated with date-time fields.

Changes

File Path Change Summary
x/oracle/keeper/aggregator/context.go Modified the Timestamp field assignment in the FillPrice method to source timestamps from msg.Prices[0].Prices[0].Timestamp
x/oracle/keeper/msg_server_create_price.go Introduced checkTimestamp function to validate message timestamps for non-emptiness, valid format, and non-future dates
x/oracle/keeper/testdata/helper.go Updated Timestamp field initialization in newPTD and newPTR functions to use a constant timestamp value t
x/oracle/types/errors.go Adjusted error codes, added a new error ErrPriceProposalFormatInvalid with code 3, and corrected ErrSample registration code
testutil/keeper/oracle.go Added import for time and included current UTC time in context ctx initialization using tmproto.Header{}

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MsgServer
    participant Keeper
    participant Clock

    User ->> MsgServer: Create Price Message
    MsgServer ->> MsgServer: checkTimestamp()
    MsgServer ->> Clock: Validate Timestamp
    Clock -->> MsgServer: Timestamp Validated
    MsgServer ->> Keeper: Store Price with Timestamp
    Keeper ->> User: Price Stored Successfully

Poem

In fields of green where data sways,
We tweaked the times in subtle ways,
Errors numbered, clean and sleek,
Now our prices hum and speak.
Code refined in lines so sure,
Our oracle's wisdom shall endure.
🌸💻⏰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloud8little commented 2 months ago

Test passed, the timestamp is added to the price info.

exocored q oracle show-prices 1
prices:
  next_round_id: "4"
  price_list:
  - decimal: 0
    price: ""
    round_id: "0"
    timestamp: ""
  - decimal: 18
    price: "318966000000"
    round_id: "1"
    timestamp: "2024-07-04 07:28:57"
  - decimal: 18
    price: "318966000000"
    round_id: "2"
    timestamp: "2024-07-04 07:28:57"
  - decimal: 18
    price: "318966000000"
    round_id: "3"
    timestamp: "2024-07-04 07:28:57"
  token_id: "1"