ExocoreNetwork / exocore

5 stars 9 forks source link

chore(ci): re-attempt fix #8

Closed MaxMustermann2 closed 4 months ago

MaxMustermann2 commented 4 months ago

This is another attempt to fix all of the Github workflows for the develop branch. Since all of our PRs will merge to develop, the base branch must have its workflows passing successfully before our changes can have their code quality assessed.

Noteworthy changes:

MaxMustermann2 commented 4 months ago

The failing "Protobuf / break-check" workflow, in my opinion, should be ignored for this pull request because the changes are only cosmetic in nature (the Go code remains unchanged). However, do note that the JSON serialization of the objects will change because their JSON name has actually changed. Per my understanding, we do not use JSON serialization outside of the genesis file or the API or the CLI; so we should be good from a chain running perspective. The staking portal could need some changes.

"Consensus Warn / main (pull_request_target)" runs on the base (default?) branch and thus will not succeed until the DeliverTx code reaches that branch.

MaxMustermann2 commented 4 months ago

If it is necessary to do so, the old JSON serialization can be retained with the json_name field. However, I would prefer to follow the recommended convention and make the changes within the consumers of the JSON API like the staking portal instead.

MaxMustermann2 commented 4 months ago

Since the JSON API change will not be immediately deployed to our nodes, I will send a draft PR to the staking portal to account for it. The deployment will have to be coordinated amongst the two.