search

Exocortex / ExocortexCrate

http://exocortex.com/products/crate
BSD 3-Clause "New" or "Revised" License
134 stars 68 forks source link

Inconsistent indentation levels #40

Closed AWhetter closed 8 years ago

AWhetter commented 8 years ago

The code style is inconsistent between files and also in files.

For most things this isn't a big deal but the main problem is the indentation is inconsistent (eg https://github.com/Exocortex/ExocortexCrate/blob/31c808272cfb25e74eb1a79151eebce41718701d/Maya/AlembicWriteJob.cpp). As a new contributor it would make the code a lot easier to understand if an indentation level was agreed upon and than standardized in the source files.

There are other style inconsistencies like usage of brackets in if chains (eg https://github.com/Exocortex/ExocortexCrate/blob/31c808272cfb25e74eb1a79151eebce41718701d/Maya/AlembicWriteJob.cpp#L515-L566) and spacing between operators, but these are not as important for understanding the code.

bhouston commented 8 years ago

If you wanted to run a code cleanup tool and submit a PR, that would be okay with us. :)

I believe the best automated source code formatting tool is http://clang.llvm.org/docs/ClangFormat.html

AWhetter commented 8 years ago

I have a work in progress version that looks good. I haven't tested it though, so I'll test and pull request it next week.