search

Exocortex / ExocortexCrate

http://exocortex.com/products/crate
BSD 3-Clause "New" or "Revised" License
134 stars 68 forks source link

Style fixes build fixes #51

Closed AWhetter closed 8 years ago

AWhetter commented 8 years ago

This is an alternative to #50 that fixes the build issues mentioned in #46.

The changes to ExocortexCMakeShared.txt were added originally because I was building with the "NMake Makefiles" generator instead of Visual Studio, and without the changes the stdafx precompiled header isn't generated. I think this is a CMake bug though so I've reverted the fix here and I'll post a bug to CMake.

I've also opted to add the missing includes to the Shared/CommonUtils/CommonAbcCache.h and Softimage/arnoldHelpers.h rather than just reorder the includes.

I did also have issues building 3DSMax but unrelated to the style fixes. They were because I was building with Visual Studio Express instead of Pro, so I haven't included those changes. If anyone is looking for a fix though I replaced "afxres.h" with "windows.h" in 3DSMax/Alembic.rc and added

#ifndef IDC_STATIC
#define IDC_STATIC -1
#endif

to 3DSMax/resource.h

martin-chatterjee commented 8 years ago

Great, #51 also works for me. So let's pull in #51 and forget about #50.

Cheers, Martin

martin-chatterjee commented 8 years ago

Ben,

what is your opinion on this, could we proceed in pulling in #51?

bhouston commented 8 years ago

Thanks! BTW to include me in a conversion please use @bhouston in the github comment. I have turned off github notifications (because I would get many dozens a day) except for those that mention my name.