search

Exodus-Privacy / exodus-core

Core functionality of εxodus
GNU Affero General Public License v3.0
18 stars 17 forks source link

replace %s by {} #12

Closed counter-reverse closed 4 years ago

counter-reverse commented 5 years ago

%s is a c style, it used to be used in python 2 and it should not be used anymore in python 3.

pnu-s commented 5 years ago

@counter-reverse I think your changes make sense but it has gone wild because of conflicts. Could you please try to solve them ? (or simply remake the changes on a clean new branch ?) Thanks!

counter-reverse commented 5 years ago

This MR did not work because there were another bug that appears when google play has changed icon: https://github.com/Exodus-Privacy/exodus-core/issues/13 https://github.com/Exodus-Privacy/exodus-core/issues/8. Now the bug is fixed. We should make another compilation test on this MR.

pnu-s commented 5 years ago

@counter-reverse You'll first have to merge your branch with v1 to make sure you are getting the latest changes and fix the conflicts.

counter-reverse commented 5 years ago

Really merge? Not rebase?

pnu-s commented 4 years ago

@counter-reverse Could you just use {} directly? (instead of {1}, {0}, {fingerprint}, etc.)

counter-reverse commented 4 years ago

@simpnu I read this post: https://stackoverflow.com/questions/28204936/python-format-best-practices and I believed I had to use some conventions to format that depends of the context of the code.

Now I have already replaced any {1}, {0}, {fingerprint} by {}.

pnu-s commented 4 years ago

@counter-reverse Please check my last comment