search

Exodus-Privacy / exodus-core

Core functionality of εxodus
GNU Affero General Public License v3.0
18 stars 17 forks source link

Unable to get icon from scrapping GPlay Store web page #14

Closed pnu-s closed 5 years ago

pnu-s commented 5 years ago

The following line does not work anymore because the class "covert-image" was apparently removed from the image.

https://github.com/Exodus-Privacy/exodus-core/blob/f20384135085c892e8f0983120f3db68a6782f1f/exodus_core/analysis/static_analysis.py#L315

This can cause issues and make Exodus unable to scan some applications (in case the first 2 methods of getting the icon failed).

counter-reverse commented 5 years ago

It is the source of the other issue here: https://github.com/Exodus-Privacy/exodus-core/issues/8 I have just to wait for the agreement for my pull request.

I have already fixed that here: https://github.com/Exodus-Privacy/exodus-core/pull/15.

pnu-s commented 5 years ago

Thanks @counter-reverse I'll take a look at your PR

pnu-s commented 5 years ago

Fixed in v1.0.16, waiting for integration into exodus

pnu-s commented 5 years ago

This was fixed but Google changed their class name again. :( @Gu1nness got the idea to use the filter alt = "Cover art" instead and it seems to work, we need to do that now.

pnu-s commented 5 years ago

Fixed in v1.0.17