search

Exodus-Privacy / exodus-core

Core functionality of εxodus
GNU Affero General Public License v3.0
18 stars 17 forks source link

The google play parser takes now the right image. The assertion that … #15

Closed counter-reverse closed 5 years ago

counter-reverse commented 5 years ago

…makes the checksum of the image is now adapted to make the hash of the image with the right size.

pnu-s commented 5 years ago

Hi @counter-reverse Could you make the discussed changes in your branch so that we can see to merge it ? Thanks !

counter-reverse commented 5 years ago

I learn how to use git deeper. I need to do some other stuff before the merging. I need to do it before to learn how to merge my branch. Feel free to wait. Thank you.

counter-reverse commented 5 years ago

In my opinion, the complete hash is better than the perceptual hash because it does not only check if the image exists, it also checks if the image is the expected image.

pnu-s commented 5 years ago

@counter-reverse The branch seems to have become stale and there is no real change remaining in the diff between this branch and the default branch v1.

I'm closing this right now because it seems that there is no real issue to solve here. Feel free to reopen a new one if needed.