Detect if dexdump is not available

Exodus-Privacy / exodus-core

Core functionality of εxodus

GNU Affero General Public License v3.0

18 stars 17 forks source link

Detect if dexdump is not available #17

Closed Rudloff closed 6 months ago

Rudloff commented 5 years ago

Hello,

In v2.0.2, if dexdump is not installed, detect_trackers() simply returns an empty list. I think it should raise an exception instead, because the current behavior can be confusing.

counter-reverse commented 5 years ago

In my opinion the best to do is to remove entirely dexdump from the core of exodus privacy and then recode it in python. You can check this issue: https://github.com/Exodus-Privacy/exodus-core/issues/16.

I keep in mind that detect like you want might be faster.

burkhardtc commented 3 years ago

@Rudloff You are right.

@counter-reverse I disagree. In my opinion I would prefer to solve the requirements systemwide by using the distribution package management.

apt install dexdump androguard python3-cryptography python3-jellyfish python3-traitlets python3-future python3-cffi python3-urllib3 python3-idna python3-decorator python3-ipython-genutils python3-pexpect python3-pycparser python3-pil python3-pip python3-setuptools python3-chardet python3-requests python3-certifi

pnu-s commented 6 months ago

This has been solved in the meantime, the script will fail if dexdump cannot be found.