search

Exodus-Privacy / exodus-core

Core functionality of εxodus
GNU Affero General Public License v3.0
18 stars 17 forks source link

Removes internet download of app icon #41

Closed pnu-s closed 4 years ago

pnu-s commented 4 years ago

This adds the possibility to download an icon from F-Droid -> required for https://github.com/Exodus-Privacy/exodus/issues/361

This requires to have the fdroid index located at ~/.exodus/index.xml, which will be handled by exodus. We could add that information in the documentation of this repo.

I'm open to suggestions on how to handle this a better way :)

pnu-s commented 4 years ago

@U039b that's an interesting idea, but we unfortunately cannot, because the code is in exodus-core and therefore we do not have any interaction with Minio (and especially not the credentials).

I think if we want to do this we should get back the code responsible for downloading the icon into exodus, but that may have other implications

pnu-s commented 4 years ago

@U039b Updated this PR after last discussion, removed the possibility to download an icon from internet