Exodus-Privacy / exodus-core

Core functionality of εxodus
GNU Affero General Public License v3.0
18 stars 17 forks source link

Some Firebase components are falsely reported as Firebase Analytics #97

Open maxauvy opened 4 weeks ago

maxauvy commented 4 weeks ago

Hi there, long time no see! 😄

I've stumbled across an interesting case I wanted to share with you, when analyzing an Android app 🤔

Context

Result

Do you think something can be done about this? 🙏

U039b commented 4 weeks ago

Hi @maxauvy! Nice to see you there :) Do you have any, more accurate, detection pattern in mind? Note that in its current implementation, εxodus detection cannot exclude pattern.

U039b commented 4 weeks ago

Matching on com.google.firebase.analytics.FirebaseAnalytics is probably more accurate.

maxauvy commented 4 weeks ago

That's what I had in mind, yet I didn't check against any app I know is using Firebase Analytics to confirm it's working as intended.

We could also kindly ask Google to change its packages naming convention, or to be transparent about them adding/changing things in Firebase and the associated or potential side-effects :troll:

maxauvy commented 2 weeks ago

I ran 4 manual tests, looking for com.google.firebase.analytics.FirebaseAnalytics as a detection pattern as suggested by @U039b.

So I guess it would be worth updating the tracker entry in the exodus database. I'll let you confirm it's okay with your own tests, probably more reliable than mine 😁

ignoramous commented 1 day ago

This wrongful detection of labeling apps with "analytics" for using "crashlytics" is causing some of us building FOSS apps a lot of grief, because a few trust whatever Exodus shows them over whatever our code has.