search

Exodus-Privacy / exodus-standalone

εxodus CLI client for local analysis
GNU Affero General Public License v3.0
77 stars 13 forks source link

Update Workflow to push image on Docker Hub #42

Closed Jean-BaptisteC closed 2 years ago

Jean-BaptisteC commented 2 years ago

Update Workflow to push image on Docker Hub Add two jobs on workflow:

build_latest_image and build_tag_image is execute only if job build is successful.

Just needs add token and username docker on secrets

Jean-BaptisteC commented 2 years ago

@pnu-s can you check actions permissions on settings to authorize Docker Actions

pnu-s commented 2 years ago

This way, it looks like we are doing some steps twice where we could do them only once.

Could we have only one push job, with the if conditions in the end?

pnu-s commented 2 years ago

I'll take a look on how to add the required token.

Jean-BaptisteC commented 2 years ago

To allow Docker actions, you need to changes policies in organization settings -> actions permissions -> policies

Jean-BaptisteC commented 2 years ago

How create docker Token

pnu-s commented 2 years ago

Seems like the checks did not run, do you know why?

Otherwise, LGTM

Jean-BaptisteC commented 2 years ago

Check this to allow workflow Docker https://github.com/Exodus-Privacy/exodus-standalone/pull/42#issuecomment-1086900392 Check this to create Github Secrets https://github.com/Exodus-Privacy/exodus-standalone/pull/42#issuecomment-1121437179

pnu-s commented 2 years ago

Secrets are already created. All workflows should now be allowed.

Jean-BaptisteC commented 2 years ago

I have update runs-on to trigger workflow