Exodus-Privacy / exodus

Platform to audit trackers used by Android application
https://reports.exodus-privacy.eu.org/
GNU Affero General Public License v3.0
645 stars 63 forks source link

Handle app with version name with > 50 characters #300

Open pnu-s opened 4 years ago

pnu-s commented 4 years ago

Currently there is a bug with application which versions / version codes have more than 50 characters.

This is not handled properly so the analysis hangs forever with the message "Tracker analysis: success"

Example: https://play.google.com/store/apps/details?id=ch.sbb.mobile.android.preview and its version flavorpreviewRelease-10.0.0.191210.1822.126-RELEASE

Couple of possible solutions:

codeurimpulsif commented 4 years ago

I think extend the max characters limit in database is a good solution. (Truncating leads to information loss and I think it's better to have complete values)

Maybe we can try with 100 characters ?

pnu-s commented 4 years ago

Agreed, makes sense to me :)

What we could do:

pnu-s commented 4 years ago

Got the same issue this morning with a permission too long (https://play.google.com/store/apps/details?id=com.sec.android.app.sbrowser.beta)

Not sure if this is related to a recent change as I don't think so we were seeing this before but we need to at least handle these cases properly

pnu-s commented 4 years ago

Note: I made a quick change to fail properly when this happens instead of hanging forever

Jean-BaptisteC commented 2 years ago

Since june 2021, i have analyse more 10 000 apps and the number of apps with versionName have more 50 characters is weak. https://play.google.com/store/apps/details?id=com.google.android.tts

U039b commented 2 years ago

We could increase the limit.