ExodusMovement / cryptocompare

CryptoCompare JavaScript API
MIT License
244 stars 80 forks source link

iOS 9.x = Unexpected keyword 'const'. Const declarations are not supported in strict mode. #30

Closed abdul closed 6 years ago

abdul commented 6 years ago

I am wondering if this library support < iOS 10 system? Safari on iOS 9.3 throws the error "Unexpected keyword 'const'. Const declarations are not supported in strict mode.".

I didn't realise that many people still use iOS 9.3, hence I am being asked to sort this issue out -- we happen to use your library for one of our products.

I can fork, fix, and use the module but I prefer if it's sorted out here -- so it's less of cost of ownership for everyone :-)

Thank you

RyanZim commented 6 years ago

No, it doesn't support iOS 9.3. iOS 9.3 is used by less than 1% of the world, so we won't be adding support. https://caniuse.com/#feat=const

I'd suggest transpiling all your code using https://babeljs.io/ if you need such support.

abdul commented 6 years ago

I just did that - transpiling. Thank you for your prompt response.

On Thu, 11 Oct 2018 at 4:25 AM, Ryan Zimmerman notifications@github.com wrote:

No, it doesn't support iOS 9.3. iOS 9.3 is used by less than 1% of the world, so we won't be adding support. https://caniuse.com/#feat=const

I'd suggest transpiling all your code using https://babeljs.io/ if you need such support.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ExodusMovement/cryptocompare/issues/30#issuecomment-428760760, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD8ONww0qK7fWbDF4VxIyBH5OeC_sqzks5ujnrqgaJpZM4XWdCq .

-- Sent from phone - please ignore typos if any. Thank you.