Exolius / SimpleBackup

A bukkit plugin to zip up specified maps at regular intervals.
20 stars 19 forks source link

Just to let you know that I added delete functionality in my fork, you may want to check it out. #2

Closed mantun closed 12 years ago

Exolius commented 12 years ago

Nice work adding all of that, i've slowed down a lot with developing recently.

Since your doing work on the plugin more than me how would you feel about taking over the plugin development?

mantun commented 12 years ago

One thing I like in the plugin is its simplicity and so I am reluctant to add any features to it. That is why I didn't send a pull request for what I've done. The delete feature I needed and implemented is kind of elaborate and I'm not sure if it fits the plugin theme.

Right now I got the plugin working exactly as I need and currently I don't plan adding more functionality. I'll only fix bugs if needed.

I've done two major things:

  1. General cleanup - I refactored the code without changing the functionality - see https://github.com/mantun/SimpleBackup/commit/245c6b7dab5c8e75b78385bcb673d2a38c595805 for detailed list of the changes. I definitely recommend merging this in the main branch. If you decide to do so, I can send a pull request.
  2. Delete schedule functionality - it is up to you to decide whether you want it in the plugin.

In conclusion: I don't expect more development in the plugin and thus I am not eager to take over. We (that is, you) can publish one more release with the latest changes and call it feature complete. If your intention is to resign at all, I guess I can take over to prevent the plugin from dying. Do you happen to know how many servers use the plugin? If there are not many, it'll be an easy life, because there won't be many feature requests or bug reports.

Let me know what you think.

Exolius commented 12 years ago

I'd love a pull request for what you have done, i'll just download your fork source and compile it then publish it, then when you send the pull request i'll merge it to the main branch.

Its no problem for me to recompile the plugin with new bukkit releases, but feel free to add more features if you feel like it.

UPDATE - 28/06/12 8:35AM: I downloaded your source, and pushed it to my branch, and proceeded to test the plugin to make sure it was working properly, everything worked apart from the zipping of the maps, line 183 in SimpleBackup.java ( if (destinationFile.getParentFile().exists()) { ) was being ignored completely.

If the directories didn't exist at all(for example on a complete first run of the plugin) it wouldn't zip the maps up because it couldn't find the folders, so I changed it to ( if (!destinationFile.getParentFile().exists()) { ) and everything seems to be in great working order, I haven't tested the deletion functionality yet, I may make some modifications to it if people find it difficult to use.

I can only assume how many servers use the plugin, its at 3177 downloads at the moment so I would say a decent amount or people seem to be either using it, or watching its development.

Thanks a bunch for all that work you did.

-Exolius

mantun commented 12 years ago

Good job finding this, I certainly meant 'if (!destinationFile...'.

I am looking at the comments of the plugin page and I'll try to help with some of the issues mentioned there.

Exolius commented 12 years ago

No problem.