search

Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
56 stars 12 forks source link

Tinkers' Construct Custom Cursor Compatibility #11

Closed ghost closed 5 years ago

ghost commented 5 years ago

Versions

Minecraft: 1.12.2 Forge: 14.23.5.2836 Mantle: 1.3.3.49 Tinkers' Construct: 2.12.0.135 Shoulder Surfing: 1.15

Steps to reproduce

  1. Set up a fresh forge install with Mantle, TConstruct, and Shoulder Surfing
  2. Start a new creative world
  3. Configure Shoulder Surfing:
    • Override Mod Crosshairs = false
    • All other options = true
    • Rotation offset = -20.
  4. Spawn yourself a TCon Shortbow, Longbow, or Crossbow, plus a TCon arrow or bolt.
  5. Hold the weapon and switch to third person.
  6. Observe the crosshair rendering issue
    • The crosshair and parts of the HUD (Waila/Hwyla if installed, health bar if in survival) will jitter all over the place.
    • The mod configuration menu also gets shifted partly off screen.
    • Interestingly, if Rotation Offset = 0, the jittering is massively reduced.
    • The jittering depends on the distance to the block you are looking at. There is a "sweet spot" about 4 blocks away where the jittering is minimized.

Thoughts / Suggestions

Not sure if this can be fixed form Shoulder Surfing's side or if it is a Tinkers' Construct issue. It would be great to have the Tinkers' Construct crosshairs working with this mod.

If it cannot be fixed, perhaps the "Override Mod Crosshairs" option could be split into "Override Mod Crosshairs in First Person" and "Override Mod Crosshairs in Third Person" as a workaround. That way the TCon crosshairs would still be available in first person, and dynamic crosshair would still work seamlessly in third.

Exopandora commented 5 years ago

This is hard to fix with workarounds. TConstruct could fix this easily if they would start using the right event (RenderGameOverlayEvent.Pre instead of RenderGameOverlayEvent). I suggest using "Override Mod Crosshairs" as it partially fixes the issue and was implemented for such reasons.

Regarding your thoughts/suggestions: In the next update "Override Mod Crosshairs" will only work in third person. I hope this will help.

ghost commented 5 years ago

Thanks for the quick update! The change is working great -- TCon's crosshairs work in first person, and i have a stable dynamic crosshair in 3rd person. I've opened an issue over at Tinker's Construct as well linking back to this thread with your suggestion. Hopefully they can fix it the rest of the way, if not, it's working well enough now for my purposes. Thanks again!