search

Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
48 stars 9 forks source link

[FEATURE] [1.19.2] Allow the skipRenderPlayer camera distance to be configurable. #116

Closed Tmktahu closed 1 year ago

Tmktahu commented 1 year ago

Describe your feature When playing Origins where your character size is smaller than normal, this mod is fantastic. But when keepCameraOutOfHead is enabled, the distance that it begins to hide the character is too large, causing the player rendering to always be skipped. WIthout this setting on, it can be very difficult to mine in tiny tunnels or operate next to walls.

At the moment, the value is hardcoded to 0.80 on line 159 of ShouldRenderer.java.

I suggest making that a configurable value instead.

I would do it myself and put a PR together, but I'm not familiar with how to correctly initialize a new configuration option or compile the mod once the change is done.

Exopandora commented 1 year ago

Thanks for reporting! This issue has already been reported a few weeks ago. I was thinking about making the distance dependant on the player size (see #115), but i never came around to actually test it. I will try to make it in the coming days.

Exopandora commented 1 year ago

This has been addressed in SSR release 2.3.2. Thanks again for the report.