search

Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
48 stars 9 forks source link

[BUG] [1.12-2.4.1] Crosshair misaligned with targeting block #127

Closed Ldawsonm closed 11 months ago

Ldawsonm commented 11 months ago

Description

Fairly straightforward. If you have your crosshair's raised above your head (y-offset > 0), then the block at which your crosshair is pointing will not be the same as the block you're actually pointing at. This remains true whether or not you have replaceDefaultPerspective set to true.

Steps to Reproduce

  1. Increase y-offset of crosshair (either in config or with PAGEUP)

Expected Behavior

The targeted block should be aligned with wherever the crosshair is pointed.

Screenshots

image Notice how the crosshair is aimed at the grass block under the shrub, yet the actually targeted block is the one closer to me.

Game Logs

No Logs

Other Mods

No response

Additional Information

If this issue is not reproducible, then it could perhaps be an issue on my end. I am running about 200+ mods, but none of them affect the third person perspective, so I omitted the mod list from this ticket.

Exopandora commented 11 months ago

Thanks for the report! This looks like a compatility issue with another mod you have: image

Ldawsonm commented 11 months ago

Ah, my apologies, it appears the incapability comes from Reach Fix. I looked through both configs and it appears there is simply no way to make the two work together.

Update: It does work when the crosshair has no y-offset. So if anyone reading this has these two mods, you just can't increase the y-offset to keep the crosshair accurate

Exopandora commented 11 months ago

It looks like Reach Fix overrides the same code as SSR overrides. There is no (easy) way to make the mods compatible. Can this be closed then?

Ldawsonm commented 11 months ago

Ah yeah, that's unfortunate. Looks like that's case closed then. Thank you so much for your help and responsiveness!

Sokusha commented 11 months ago

Oh, I've also encountered similar problem before, I go to SSR's config and change the crosshair_type = "ADAPTIVE" to crosshair_type = "DYNAMIC" then the problem was solved

Exopandora commented 11 months ago

Oh, I've also encountered similar problem before, I go to SSR's config and change the crosshair_type = "ADAPTIVE" to crosshair_type = "DYNAMIC" then the problem was solved

Yes, that should solve the issue, as the dynamic crosshair does not change any raytracing.