[BUG] [1.19.2] Incompatibility with Valkyrien Skies

[raffle2]

Description

Henlo! It seems that at the moment when I aim my crosshair at a block, and even if that block has the placement outline, on right click I will always place something offset to the left or in front of it instead.

I also tested this without Dynamic Crosshair and Better Third Person as I thought they could be conflicting with this mod but the problem persists.

Steps to Reproduce

1. Aim at block
2. Right click to place a block.

Expected Behavior

A block should be placed where I am aiming, not to the side.

Screenshots

Here's a video of it in action: https://bunkrr.su/v/c0T6qVDDsJ9Xk

Game Logs

https://gist.github.com/raffle2/646bfc5bdc3b5981d285efb80510882e

Other Mods

No response

Additional Information

No response

[Exopandora]

Thanks for the report! It would be very helpful if you could figure out what mod(s) cause the issue. To quickly find the conflicting mods, you can use binary search.

[raffle2]

Thank you, I have quite a few mods so I'll take my time and get back to you asap!

[raffle2]

Thanks for the report! It would be very helpful if you could figure out what mod(s) cause the issue. To quickly find the conflicting mods, you can use binary search.

Found the culprit! It's Valkyrien Skies! I followed your method and then just ran the game with all mods but this one active and I could place things correctly as expected. Do you think this is something fixable however?

[Exopandora]

Thanks finding the conflicting mod. There has been reports about incompatibilities with Valkyrien Skies in the past (see #10, #108, #114). Some of which could be resolved. However, this one is not easily resolvable from my side, as Valkyrien Skies modifies the exact same line of code that Shoulder Surfing tries to modify. Even if i would be able to fix it, it would probably not work correctly when mounted on a ship. However, it might be possible for Valkyrien Skies to implement a plugin system, similar to the ones found in WTHIT or Jade for block and entity tracing, which could finally resolve the issue. I will open up an issue on their github repository.

[raffle2]

Thank you so much, I hope it's something that can be done on their end c:

[raffle2]

Hey again, sorry to bother you once more :( I was wondering if there's any temporary fix that could be done while the issue is not solved on VS2 side? Even if SSR would break while on a ship, I'd be ok with it as long as it SSR would work as intended everywhere else. Both mods are super crucial to my modpack so it's hard to make a choice between the two and I wouldn't mind having to deal with a compromise like this :)

[Exopandora]

Sorry for the late reply. While it is theoretically possible, I unfortunately do not have the time at the moment.

[raffle2]

Sorry for the late reply. While it is theoretically possible, I unfortunately do not have the time at the moment.

I understand :( Thanks for the work so far

[Exopandora]

Closing this, as Valkyrien Skies is no longer supported in Shoulder Surfing Reloaded version 3.0.0+. Feel free to re-open this issue once Valkyrien Skies improved compatibility for custom ray tracing implementations.