Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
48 stars 9 forks source link

[BUG] [1.12.2] No player model is displayed #154

Closed al-wei closed 4 months ago

al-wei commented 4 months ago

Description

No player model is displayed

ShoulderSurfing-1.12.2-2.9.1

Steps to Reproduce

no

Expected Behavior

no

Screenshots

image

Game Logs

no

Other Mods

No response

Additional Information

No response

Exopandora commented 4 months ago

Thank you for the report. This looks like a compatibility issue with another mod. Please fill in all the fields of the issue template, otherwise I am not able to fix this issue. You can use this method to find the conflicting mod. As a temporary workaroud, you can try setting "Adjust player transparency" to false.

al-wei commented 4 months ago

Thank you for the report. This looks like a compatibility issue with another mod. Please fill in all the fields of the issue template, otherwise I am not able to fix this issue. You can use this method to find the conflicting mod. As a temporary workaroud, you can try setting "Adjust player transparency" to false.

Sorry, I forgot about compatibility. [FBP]Fancier Block Particles image

Exopandora commented 4 months ago

Please report this issue to the authors of FBP. It works fine with FBP 0.7, but is broken in FBP 0.8. I am suspecting that this is an issue with mixin, as it looks like the changes made by shoulder surfing get completely overridden. There is no known way to me to fix this, other than also using mixins, which i will not invest the time in, to do so for this version.

al-wei commented 4 months ago

Please report this issue to the authors of FBP. It works fine with FBP 0.7, but is broken in FBP 0.8. I am suspecting that this is an issue with mixin, as it looks like the changes made by shoulder surfing get completely overridden. There is no known way to me to fix this, other than also using mixins, which i will not invest the time in, to do so for this version.

Ouch! In that case, I prefer to use the 2.8.x version, maybe modpack won't wait for them to fix it.

Exopandora commented 4 months ago

You mentioned that it worked with 2.8.x, which got me thinking again. In 2.9.x, some optimizations were made, so code changes to the minecraft code base at runtime will not applied twice, since the code should only load once. But with mixin installed, they load twice. I reverted the optimization change and now it works again. I will release a new version soon, but I want to fix another bug first. Thanks again for reporting!