Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
48 stars 9 forks source link

[Invisible Crosshair And Sliding Crosshair] [1.20.1] Sliding Crosshairs #158

Closed Fyoncle closed 4 months ago

Fyoncle commented 4 months ago

Description

It is an glitch that making your crosshair invisible in F5 defaults, and while in shoulder surfing mode your crosshair will slide right to left in your scenes and makes it unstable to control

Steps to Reproduce

  1. Press F3 Just 3 Times
  2. Move Your Crosshair Right To Left
  3. Also Invisible Crosshairs On Default F3 Which is first and second.

Expected Behavior

I wanted crosshairs back and not sliding standing still shoulder surfing "LIKE BEFORE THE UPDATE THAT IS BREAKED IT"

Screenshots

No response

Game Logs

There's no obvious glitches in the log at all, try it for yourself and its just a visual glitch.

Other Mods

No response

Additional Information

No response

Exopandora commented 4 months ago

This looks like a configuration issue. The configuration file can be found in .../.minecraft/config/shouldersurfing.toml. There, you can set the visibility for each perspective individually:

[crosshair.visibility]
#Crosshair visibility for first_person.
#Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
first_person = "ALWAYS"
#Crosshair visibility for shoulder_surfing.
#Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
shoulder_surfing = "ALWAYS"
#Crosshair visibility for third_person_back.
#Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
third_person_back = "NEVER"
#Crosshair visibility for third_person_front.
#Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
third_person_front = "NEVER"

If you do not want the camera moving left to right, depending on space constraints, you can either set camera_transition_speed_multiplier to 1.0 or dynamically_adjust_offsets to false.

Fyoncle commented 4 months ago

Owner

Before the update that wasn't happening, can u fix by any chance into like it was in previous update?? since the right and left sliding is a WHOLE GLITCH, plus, you cannot break ANY grass while in shoulders surfing mod (not grass block, grass itself.)

Exopandora commented 4 months ago

Please share your config file and game logs. Without them I cannot take further action.

Fyoncle commented 4 months ago

Please share your config file and game logs. Without them I cannot take further action.

Okay, can you give me a few minutes so i can get the logs?

Exopandora commented 4 months ago

Also, what "previous update" are you referring to exactly (minecraft version and shoulder surfing verion)?

Fyoncle commented 4 months ago

Also, what "previous update" are you referring to exactly (minecraft version and shoulder surfing verion)?

It wasn't happening in shoulder surfing 2.8.2 but when i updated to latest after few days, it started glitching like that.

Fyoncle commented 4 months ago

Also, what "previous update" are you referring to exactly (minecraft version and shoulder surfing verion)?

Also just tried the mod again with no any other mods, the glitch seem not to continue... i wonder what mod shoulder surfing having incompatibility with??, if i send you the shoulder surfing glitch happening in my modpack with the whole modpack's log, you would be able to find it??

Exopandora commented 4 months ago

if i send you the shoulder surfing glitch happening in my modpack with the whole modpack's log, you would be able to find it??

Most likely not. Please use this method to find the conflicting mod. On a side note: There weren't any changes to shoulder surfing regarding camera and crosshair position in the latest update (2.9+). Most likely, you added another mod together with updating shoulder surfing. Also, it would be very helpful if you could attach screenshots or even a short video of the bug happening.

Fyoncle commented 4 months ago

if i send you the shoulder surfing glitch happening in my modpack with the whole modpack's log, you would be able to find it??

Most likely not. Please use this method to find the conflicting mod. On a side note: There weren't any changes to shoulder surfing regarding camera and crosshair position in the latest update (2.9+). Most likely, you added another mod together with updating shoulder surfing. Also, it would be very helpful if you could attach screenshots or even a short video of the bug happening.

Oh, it's a clear pain... but ill try :(

Fyoncle commented 4 months ago

if i send you the shoulder surfing glitch happening in my modpack with the whole modpack's log, you would be able to find it??

Most likely not. Please use this method to find the conflicting mod. On a side note: There weren't any changes to shoulder surfing regarding camera and crosshair position in the latest update (2.9+). Most likely, you added another mod together with updating shoulder surfing. Also, it would be very helpful if you could attach screenshots or even a short video of the bug happening.

Also heres the bug, crosshair moving by itself so weirdly when i walk or do anything and also i cannot hit to ANY GRASS.

https://github.com/Exopandora/ShoulderSurfing/assets/63975256/e83b300b-141e-41a0-baa0-beb909f7a6a9

Exopandora commented 4 months ago

This is the "dynamic" crosshair. It has always worked like this and is always enabled when you have set crosshair_type to DYNAMIC in your config file. To get back the default behavior, set crosshair_type to ADAPTIVE. The fact that you are not able to break any grass is a bug of the dynamic crosshair. Setting it back to adaptive will also fix that issue.

Fyoncle commented 4 months ago

This is the "dynamic" crosshair. It has always worked like this and is always endabled when you have set crosshair_type to DYNAMIC in your config file. To get back the default behavior, set crosshair_type to ADAPTIVE. The fact that you are not able to break any grass is a bug of the dynamic crosshair. Setting it back to adaptive will also fix that issue.

but without that modpack it doesnt work "LIKE THAT", without modpack the config different, with modpack is the config different? how that even works :(

Exopandora commented 4 months ago

What modpack are you using?

Fyoncle commented 4 months ago

What modpack are you using?

A custom one i made, i can sent you if you want? do you have discord or smt (i dont have the list of the mods, im too lazy to get em.)

Exopandora commented 4 months ago

Can you upload your config file of SSR first? I think the issue somewhere in there.

Fyoncle commented 4 months ago

Can you upload your config file of SSR first? I think the issue somewhere in there.

what is SSR?

Exopandora commented 4 months ago

Shoulder Surfing Reloaded

Fyoncle commented 4 months ago

Shoulder Surfing Reloaded

[perspective]
    #The distance multiplier on whether or not to hide the player model if the camera gets too close to it. Set to 0 to disable.
    #Range: 0.0 ~ 1.7976931348623157E308
    keep_camera_out_of_head_distance_multiplier = 0.75
    #The default perspective when you load the game.
    #Allowed Values: FIRST_PERSON, THIRD_PERSON_BACK, THIRD_PERSON_FRONT, SHOULDER_SURFING
    default_perspective = "SHOULDER_SURFING"
    #Whether or not to remember the last perspective used.
    remember_last_perspective = true
    #Whether or not to replace the default third person perspective.
    replace_default_perspective = false
    #Whether or not to skip the third person front perspective.
    skip_third_person_front_perspective = false
    #Whether or not to limit the player reach depending on the crosshair location (perspective offset).
    limit_player_reach = true
    #Size of the camera adjustment per step.
    #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
    camera_step_size = 0.025
    #Whether or not to temporarily center the camera when climbing.
    center_camera_when_climbing = true
    #The speed multiplier at which the camera transitions between positions.
    #Range: 0.05 ~ 1.0
    camera_transition_speed_multiplier = 0.25
    #The angle at which the camera will be centered when looking down. Set to 0 to disable.
    #Range: 0.0 ~ 90.0
    center_camera_when_looking_down_angle = 15.0
    #The angle at which the player will no longer be rendered when looking up. Set to 0 to disable.
    #Range: 0.0 ~ 90.0
    hide_player_when_looking_up_angle = 15.0
    #Whether or not to dynamically adjust camera offsets depending on space constraints.
    dynamically_adjust_offsets = true
    #Whether or not to adjust the player model transparency when view is obstructed.
    adjust_player_transparency = true

    [perspective.offset]
        #Third person camera x-offset.
        #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
        offset_x = -0.75
        #Third person camera y-offset.
        #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
        offset_y = 0.0
        #Third person camera z-offset.
        #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
        offset_z = 3.0

        [perspective.offset.min]
            #If x-offset is limited this is the minimum amount.
            #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
            min_offset_x = -3.0
            #If y-offset is limited this is the minimum amount.
            #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
            min_offset_y = -1.0
            #If z-offset is limited this is the minimum amount.
            #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
            min_offset_z = -3.0

        [perspective.offset.max]
            #If x-offset is limited this is the maximum amount.
            #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
            max_offset_x = 3.0
            #If y-offset is limited this is the maximum amount.
            #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
            max_offset_y = 1.5
            #If z-offset is limited this is the maximum amount.
            #Range: -1.7976931348623157E308 ~ 1.7976931348623157E308
            max_offset_z = 5.0

        [perspective.offset.limits]
            #Whether or not x-offset adjustment has limits.
            unlimited_offset_x = false
            #Whether or not y-offset adjustment has limits.
            unlimited_offset_y = false
            #Whether or not z-offset adjustment has limits.
            unlimited_offset_z = false

        [perspective.offset.multiplier]

            [perspective.offset.multiplier.passenger]
                #x-offset multiplier for when the player is a passenger.
                #Range: 0.0 ~ 1.7976931348623157E308
                multiplier_offset_x = 1.0
                #y-offset multiplier for when the player is a passenger.
                #Range: 0.0 ~ 1.7976931348623157E308
                multiplier_offset_y = 1.0
                #z-offset multiplier for when the player is a passenger.
                #Range: 0.0 ~ 1.7976931348623157E308
                multiplier_offset_z = 1.0

            [perspective.offset.multiplier.sprint]
                #x-offset multiplier for when the player is sprinting.
                #Range: 0.0 ~ 1.7976931348623157E308
                multiplier_offset_x = 1.0
                #y-offset multiplier for when the player is sprinting.
                #Range: 0.0 ~ 1.7976931348623157E308
                multiplier_offset_y = 1.0
                #z-offset multiplier for when the player is sprinting.
                #Range: 0.0 ~ 1.7976931348623157E308
                multiplier_offset_z = 1.0

[crosshair]
    #Crosshair type to use for shoulder surfing.
    #Allowed Values: ADAPTIVE, DYNAMIC, STATIC, STATIC_WITH_1PP, DYNAMIC_WITH_1PP
    crosshair_type = "ADAPTIVE"
    #The raytrace distance used for the dynamic crosshair.
    #Range: 0.0 ~ 1.7976931348623157E308
    custom_raytrace_distance = 400.0
    #Whether or not to use the custom raytrace distance used for the dynamic crosshair.
    use_custom_raytrace_distance = true
    #Items that when held, trigger the dynamic crosshair in adaptive mode.
    adaptive_crosshair_hold_items = ["minecraft:snowball", "minecraft:egg", "minecraft:experience_bottle", "minecraft:ender_pearl", "minecraft:splash_potion", "minecraft:fishing_rod", "minecraft:lingering_potion"]
    #Items that when used, trigger the dynamic crosshair in adaptive mode.
    adaptive_crosshair_use_items = []
    #Item properties of an item, that when held, trigger the dynamic crosshair in adaptive mode.
    adaptive_crosshair_hold_item_properties = ["minecraft:charged"]
    #Item properties of an item, that when used, trigger the dynamic crosshair in adaptive mode.
    adaptive_crosshair_use_item_properties = ["minecraft:pull", "minecraft:throwing"]

    [crosshair.visibility]
        #Crosshair visibility for fırst_person.
        #Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
        "fırst_person" = "ALWAYS"
        #Crosshair visibility for thırd_person_back.
        #Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
        "thırd_person_back" = "NEVER"
        #Crosshair visibility for thırd_person_front.
        #Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
        "thırd_person_front" = "NEVER"
        #Crosshair visibility for shoulder_surfıng.
        #Allowed Values: ALWAYS, NEVER, WHEN_AIMING, WHEN_IN_RANGE, WHEN_AIMING_OR_IN_RANGE
        "shoulder_surfıng" = "ALWAYS"
Exopandora commented 4 months ago

Please use this method to find the conflicting mod.

Strange, everything looks correct. The only option left is to find the conflicting mod(s) with the method described above.

Fyoncle commented 4 months ago

Please use this method to find the conflicting mod.

Strange, everything looks correct. The only option left is to find the conflicting mod(s) with the method described above.

Isn't theres a better way...? that will consume lot of time 🥺

Exopandora commented 4 months ago

Unfortunately, this is the fastest method.

Fyoncle commented 4 months ago

Unfortunately, this is the fastest method.

Okay then, ill find the mod and let you know...

Fyoncle commented 4 months ago

Unfortunately, this is the fastest method.

Okay okay okay, the glitch was because of the "MODRINTH LAUNCHER ITSELF" because of the launcher sinytra connector extras somehow crashes on minecraft launcher but doesn't on the modrinth launcher, and this glitch of your mod is ONLY HAPPENS IN MODRINTH LAUNCHER, somehow that is how it is im pretty much confused.

Exopandora commented 4 months ago

Can you provide the logs of both launches?

Fyoncle commented 4 months ago

Can you provide the logs of both launches?

Is it safe to share logs btw? Sorry i don't know much so i just wanted to ask

Exopandora commented 4 months ago

Yes, logs are usually safe to share. If you are not sure, you can open them in a text editor before uploading them.

Fyoncle commented 4 months ago

Exopandora

Ok... so im suffering right now somehow? i am literally going crazy because of the glitches, since i tried to get the logs for you then SOMEHOW IT BROKE IN THE NORMAL LAUNCHER TOO... AND THEN I FIXED BY CHANGING FABRIC API VERSION, AND IT WORKED THEN I DELETED THE CONNECTOR THEN IT ALSO GOT FIXED IN MODRINTH BUT THEN IT GAVE ERROR ABOUT FORGE API AND THEN IT GOT CONFUSED WITH CLOTH API!?!?!?!? AND THEN CLOTH API'S VERSION'S FORGE VERSION'S FABRIC VERSION huh... i am so confused about what the hell did i just witness but that is actually mind breaking... So in the end i think the cause of that was actually the Sinytra Connector mod. (I cannot give you logs anymore since the normal launcher got broke too somehow :c )

Exopandora commented 4 months ago

I tested with the following setup and it worked just fine (vanilla launcher):

I suggest you figure out your setup by adding one mod at a time and see when it breaks. Try to use matching versions and mods for the correct mod loader. If there are still issues, please provide the log for that specific launch, thanks.

Fyoncle commented 4 months ago

I tested with the following setup and it worked just fine (vanilla launcher):

  • Connector-1.0.0-beta.37+1.20.1.jar
  • ConnectorExtras-1.9.3+1.20.1.jar
  • fabric-api-0.92.0+1.11.3+1.20.1.jar
  • ShoulderSurfing-Forge-1.20.1-2.9.4.jar
  • Forge 47.1.3

I suggest you figure out your setup by adding one mod at a time and see when it breaks. Try to use matching versions and mods for the correct mod loader. If there are still issues, please provide the log for that specific launch, thanks.

Yea but i don't really wanna continue trying it because my brain literally hurts, i been trying to figure out which mods does that for 5 hours and the things happening in the last hour literally got my iq into minus, so basically if u want i can give you the modpack file with exporting from modrinth and u experiment "better" than me?

Exopandora commented 4 months ago

I think you will be able to figure it out. Take your time!

Fyoncle commented 4 months ago

I think you will be able to figure it out. Take your time!

So i ported my modpack into fabric and i still have the same issue, can i sent the log to you because i am out of ideas, its not caused by a "Mod" but i believe its "Mods", it works so weirdly in a level that i don't wanna check all 200 mods for nothing because the result will be the same without a solution.

Fyoncle commented 4 months ago

I think you will be able to figure it out. Take your time!

So i ported my modpack into fabric and i still have the same issue, can i sent the log to you because i am out of ideas, its not caused by a "Mod" but i believe its "Mods", it works so weirdly in a level that i don't wanna check all 200 mods for nothing because the result will be the same without a solution.

https://mclo.gs/SSTKyj9 Heres the log you need, exopandora. (dont mind the cull leaves error i forget to remove this mod eheheh)

Exopandora commented 4 months ago

Thanks for the upload. Unfortunately, there is no new information in the log. If the issue happens WITH the vanilla minecraft laucher, you can upload your mods and config folder somewhere, so i can take a closer look.

Fyoncle commented 4 months ago

Thanks for the upload. Unfortunately, there is no new information in the log. If the issue happens WITH the vanilla minecraft laucher, you can upload your mods and config folder somewhere, so i can take a closer look.

Oof this is getting close to impossible to fix.

Fyoncle commented 4 months ago

Thanks for the upload. Unfortunately, there is no new information in the log. If the issue happens WITH the vanilla minecraft laucher, you can upload your mods and config folder somewhere, so i can take a closer look.

Here :(

Config ; shouldersurfing.txt

Log ; https://mclo.gs/erQtPb7

Exopandora commented 4 months ago

I meant your mods folder with all the jars (.minecraft/mods/) and your config folder (.minecraft/config/). 😃

Fyoncle commented 4 months ago

I meant your mods folder with all the jars (.minecraft/mods/) and your config folder (.minecraft/config/). 😃

oh... the file would be too big to sent, github got 10 mb limit and modpack is 300 mb :c i sent you a request from discord, if u can accept i can give you the files here.

Exopandora commented 4 months ago

The issue is caused by medieval weapons

Exopandora commented 4 months ago

The issue is also present in earlier versions of SSR.

Fyoncle commented 4 months ago

The issue is caused by medieval weapons

Thank you so much for your helps, i appreicate that. ❤

Exopandora commented 4 months ago

Alternatively, you can remove "minecraft:throwing" from adaptive_crosshair_use_item_properties in shouldersurfing.toml. However, this will make it so throwing weapons, like the trident, will not trigger the adaptive crosshair. Techincally, you could then add those throwing weapons to the adaptive_crosshair_hold_items in order to get the adaptive crosshair back.