search

Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
48 stars 9 forks source link

[BUG] [1.20.4] Partially incompatible with Spyglass Improvements #165

Closed SplendidAlakey closed 3 months ago

SplendidAlakey commented 3 months ago

Description

When using the mod together with Spyglass Improvements, using the spyglass while in shoulder perspective, the view is obstructed by a solid spyglass texture.

Steps to Reproduce

  1. Just use the spyglass in shoulder perspective

Expected Behavior

Clear view through the spyglass.

Screenshots

How it is: on How it should be: off

Game Logs

https://gist.github.com/SplendidAlakey/70f1d2f50aa5c42764bf3fbab8a25c9a

Other Mods

Spyglass Improvements 1.4

Additional Information

The issue only happens with Shoulder Surfing Reloaded 2.9.1+. Version 2.8.1 does not produce the same issue.

Exopandora commented 3 months ago

Thanks for the report! Although this bug is fixed, due to other new features coming to Shoulder Surfing Reloaded, it is no longer possible to move around your view in third person when spyglass improvements is installed and looking through a spyglass. This is caused by the way spyglass improvements is implemented, and can only be fixed by its authors. Instead of cancelling the vanilla implementation of MouseHandler.turnPlayer, they should only modify the method arguments of Player.turn and Tutorial.onMouse, or they should modify individual local variables. I suggest reporting this to the authors of spyglass improvements.

Exopandora commented 2 months ago

I revised my side of the implementation and there are no more conflicts. juancarloscp52/spyglass-improvements#44 can be closed. The update will be released soon.