Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
46 stars 9 forks source link

Incompatible with Capes #220

Closed Zh40Le1ZOOB closed 1 day ago

Zh40Le1ZOOB commented 1 week ago

Description

The game auto reload resources packs and get stuck while launching, with Capes and 3D Skin Layers and installed.

See https://github.com/CaelTheColher/Capes/issues/135 https://github.com/tr7zw/3d-Skin-Layers/issues/159

Minecraft version

1.21

Incompatible mod name

Capes, 3D Skin Layers

Incompatible mod version

1.5.4, 1.6.6

Game Logs

https://mclo.gs/oZontXQ

Exopandora commented 1 week ago

Thanks for reporting. The issue is caused by a mixin conflict between Capes and Shoulder Surfing Reloaded, as they try to modify the same line of the minecraft codebase. 3D Skin Layers is not involved. Unfortunately, I was not able to reproduce the issue. I suspect that it depends on a specific load order of the mods, where Shoulder Surfing Reloaded gets loaded before Capes, which should normally not happen. Most likely this is caused by using Quilt instead of Fabric. It might also be operating system specific. In order to ensure the correct loading order, I will increase the priority of the conflicting mixin, which will make it apply after Capes' modifications. Since the mixin of Shoulder Surfing Reloaded is already optional, it should not crash the game. And since both mods try to achieve the exact same thing (transparent cape rendering), both mods should work exactly as intended.

Exopandora commented 1 week ago

I pushed the fix to master. If you know how to build from source (check readme), it would be nice if you could test whether the change fixes the issue, since I cannot verify.

Zh40Le1ZOOB commented 1 week ago

Most likely this is caused by using Quilt instead of Fabric.

Yes, I'm using Quilt, but I'v not tested the Fabric. Very sorry to missing context.

Zh40Le1ZOOB commented 1 week ago

I pushed the fix to master. If you know how to build from source (check readme), it would be nice if you could test whether the change fixes the issue, since I cannot verify.

I built it from master, but the problem is still there when using Quilt. The error log is completely same.

Exopandora commented 2 days ago

I pushed another attempt for a fix. Please let me know if it fixes the problem.

Zh40Le1ZOOB commented 1 day ago

I pushed another attempt for a fix. Please let me know if it fixes the problem.

It works perfetcly!