search

Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
67 stars 13 forks source link

Epic Fight "lock on" mode #239

Closed Joe-Schmoe-123 closed 3 months ago

Joe-Schmoe-123 commented 3 months ago

Description

Epic Fight has a lock on mode that keeps your player facing a selected enemy. Shoulder Surfing doesn't rotate with the locked on direction but keeps you facing straight ahead as your player turns to face the enemy {you need to try it to see what I'm talking about). It would be great if the third person camera rotated with the player's direction.

Minecraft version

1.20.1

Incompatible mod name

Epic FIght

Incompatible mod version

20.7.4

Game Logs

https://mclo.gs/0FMKA5W

Exopandora commented 3 months ago

Thanks for reporting! Can you please describe in more detail what you mean by lockon or how to trigger it? Maybe a video would be helpful.

Joe-Schmoe-123 commented 3 months ago

It's triggered by facing an enemy and hitting G. It locks your perspective on to a target so that as you or they move you constantly face the enemy.

Exopandora commented 3 months ago

The camera now rotates with the player when in lock-on mode and camera is coupled. If you want the lock-on mode to rotate the camera even when the camera is decoupled, you need to make the following change in common/src/main/java/com/github/exopandora/shouldersurfing/compat/mixins/epicfight/MixinRenderEngine.java and build from source:

            ((AccessorCamera) camera).invokeSetRotation(yRot, xRot);
        }
-       else if(!Config.CLIENT.isCameraDecoupled())
+       else
        {
            ShoulderSurfingImpl.getInstance().getCamera().setXRot(xRot);
Joe-Schmoe-123 commented 3 months ago

Thank you! This is my favorite mod and you are great at responding to user feedback,