Closed lilgandhi1199 closed 6 years ago
I think i located the problem
I know with no offset it never escapes the block's boundaries
That's nice work though!
I pushed the update for both versions (it works now on both) and it will be available on curseforge in a few minutes/hours depending on how fast they can review it. Can you confirm that the bug is fixed so i can close the issue ?
OMG! that's awesome you figured that out. I'm so happy and will asap
Okay I'll check it out now
I think that it will have to wait until /files/ is updated because it thinks it's a dead link
The links work for me :(
yeah It must be a private link until they have confirmed it or something
Okay I see it. Testing 1.7 right now
https://imgur.com/a/ZLK35 1.12.2 at offset of -52 it barely fails
It's the same for 1.7 but I will find the number where it is okay (because that offset puts the player almost off of the screen all together anyways.
EDIT: You got me squared away with my offset though btw. It looks awesome but this is just in-case you want to fix for everybody else too
Edit2: In fact you could just set the rotation maximum and minimum default to whatever number I give you after testing (because that's what i'll be doing for my config so they can be allowed a degree of customization but not allow such simple xray out of the gate)
I think the problem is that when there is a block intersecting with the camera, the distance (from camera to player head) gets adjusted. In this case the distance is exactly the distance from the players head to the next block/wall. As a result the camera is now on the edge of the block making you able to xray. As i cant calculate the width of your camera i cant fix it.
Okay! I found that as your resolution goes up the cap has to shrink to dis-allow xray and windowed mode you have to shrink slightly more then fullscreen so make sure you test on that. I found no difference between 1.12 and 1.7 with these caps.
Also incase you doubt my results I'll tell you I had obs recording and zooming in so I know that it's pixel perfect. Only caveat I would mention is all tests were done on the right side of the character. But I'd assume it's exactly the same on either side because I still rotated 360 degrees around the character looking for holes.
1280x1024 - windowed main display Win7- 28.5 1920x1080 - windowed main display Win7 - 23.5 With 4k resolution I'm scared to find out how tight your view would get...
Then I noticed with view bobbing on it can xray for a second when you walk (not even run) into a wall too
1280x1024 - windowed main display Win7 - view bobbing on - ??.? 1920x1080 - windowed main display Win7 - view bobbing on - 16.0
Yes you can get the width of the window but how would you convert the pixels to blocks ?
I just noticed that you can xray with the default 3pp if you set fov on max
https://imgur.com/a/TNCj5 I tested with and without any other mods. Since it is in 1.12 and 1.7 obviously it's just an error in the core code so it's unimportant what version of forge I'm running in either I would suppose. Config for 1.7.10 followed by 1.12.2 I'm sure you can reproduce it no problem.
`# Configuration file
general {
Whether or not to show a crosshair in the center of the screen if nothing is in range of you
}
`
`# Configuration file
general {
Whether or not to show a crosshair in the center of the screen if nothing is in range of you
}
`