Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
51 stars 9 forks source link

Input lag bug #45

Closed JupiterSky11 closed 1 year ago

JupiterSky11 commented 3 years ago

For some reason when I press an input related to the mod it is delayed a decent bit, I've also noticed that the adjustment keys are super buggy. (Latest release.)

Exopandora commented 3 years ago

Please provide the resulting crash log from pressing F3 + C for 10 seconds while ingame.

JupiterSky11 commented 3 years ago

crash-2021-05-22_18.50.47-client.txt

JupiterSky11 commented 3 years ago

After a bit of experimenting, I've found that the delayed input updates when normal input is used, and also after a certain period of time. The glitchy adjustment is still strange though.

Exopandora commented 3 years ago

Do you know how to build from source?

Exopandora commented 3 years ago

I have spotted some issues regarding keybinds glitching out. This should be fixed in the latest commit. If you build from source you can try it out and see if it fixes your issue. Though i was not able to reproduce your "delayed input".

To build from source run the following commands in a terminal: git clone https://github.com/Exopandora/ShoulderSurfing.git cd ./ShoulderSurfing gradlew build

Note: You have to have git and java installed. You also might have to set the JAVA_HOME environment variable on your system to your java installation directory.

The jar will be located in ./build/libs/

JupiterSky11 commented 3 years ago

Fantastic, it works wonderfully! The weird delay seems to only be an issue with this mod and my mouse. Oh yeah, there's is a bit of a flickering sometimes, my framerate is rather high so it might be that. Thank you for the quick response and prompt bugfix!

Exopandora commented 3 years ago

Regarding the flickering: Did you press the buttons in any special pattern? And make sure that there are no blocks behind you so the camera does not jump due to collisions!

Exopandora commented 3 years ago

I dont think that its a frame rate related issue though, as i get up to 600fps and did not encounter any flickering. It might be caused by different file observing behaviours of linux (your setup) and windows (my setup). When the system detects a file change it will automatically reload the config file. Maybe that sometimes resets the values to an earlier state, causing the flickering.

JupiterSky11 commented 3 years ago

That's more likely the issue. I didn't do anything particular, it just happens when I use the adjustment keys. It's really noticeable when you hold it down, but it's nothing so bad that it breaks the function of the mod.

Exopandora commented 3 years ago

I made some more changes and i'm fairly confident it will be fully fixed this time. Again though you need to build from source in order to test it. If you still have the repo from the previous build you can simply run the following commands in ./ShoulderSurfing/ to get the updated version: git pull ./gradlew build

The jar will again be located in ./build/libs/

Exopandora commented 3 years ago

A release version is now available on curseforge

JupiterSky11 commented 3 years ago

Yep, works fine. Flickering is better for the most part, but it still happens from time to time. Everything else is fixed though! Glad I could help out, this is a good mod that I very much enjoy.

(I did test it and forgot to respond, sorry about that)

Exopandora commented 3 years ago

What exact linux distro are you using? And what type of drive (hdd/ssd) are you using?

JupiterSky11 commented 3 years ago

Ubuntu, and an NVMe SSD.