search

Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
48 stars 9 forks source link

[BUG] [1.18.2 Fabric] Raytrace compatibility issue with WTHIT/Jade/Hywla/Waila #85

Closed ardissaps closed 1 year ago

ardissaps commented 1 year ago

Is it possible to make hovered crosshair are the one that displayed? I will try to post on WTHIT sides too. image

deirn commented 1 year ago

WTHIT raycasts the object manually since what vanilla provide from Minecraft#hitResult is not configurable, it also doesn't pick dropped item and has a bigger hitbox for other entities.

For this issue I added an API to replace the raycasting method, IObjectPicker. The default impl is ObjectPicker. Use 4.13.0 for Minecraft 1.18.2.

Exopandora commented 1 year ago

Thank you for the quick support! I will create a plugin for it later. I also have another idea: You could implement a config option to use the vanilla hitResult which would enable direct support for ssr without any updates.

ardissaps commented 1 year ago

Hello again! @Exopandora, the mods is working great with WTHIT, thank you very much! Only 1 thing that does not work with new raytrace, liquid bucket. When we want to pur liquid both lava and water, it does not fill the one on the crosshair in 3rd person. Tried on both forge and fabric. No hurry, take your time, have a nice day! :)

Exopandora commented 1 year ago

Thanks for the report! This is now fixed in a new version. If you encounter any other issues please open up a new issue.

ardissaps commented 1 year ago

Ok! It works great now, thanks!