Exopandora / ShoulderSurfing

Shoulder Surfing Reloaded is a highly configurable third person camera mod for minecraft.
MIT License
63 stars 13 forks source link

[BUG] [1.7.10]Crash on worldgen with SereneSeasons-1.7.10-1.2.18 #93

Closed ghost closed 1 year ago

ghost commented 1 year ago

Description

This mod somehow crash game with Serene Seasons

Steps to Reproduce

Generate world

Expected Behavior

Generated world?

Screenshots

No response

Game Logs

https://gist.github.com/SegoItCh/4872fbc94a38bcb7d1e3bf03113aadec

Other Mods

No response

Additional Information

No response

Exopandora commented 1 year ago

In the logs it looks like Biomes'o'Plenty is crashing your game. Anyways, as stated here it is currently not possible to develop forge mods for 1.7.10.

ghost commented 1 year ago

There is a way to create workspaces, gregtech developer can help

ghost commented 1 year ago

./gradlew --refresh-dependencies setupDecompWorkspace build eclipse

Exopandora commented 1 year ago

Last time i checked the servers for the required mcp mappings were taken offline. But anyways the crash is not caused by ShoulderSurfing.

ghost commented 1 year ago

This mods won't be updated for sure, and it not crashing w/o Shoulder Surfing

Exopandora commented 1 year ago

It crashes on some terrain generation code caused by biomes'o'plenty. ShoulderSurfing has nothing to do with terrain gen.

ghost commented 1 year ago

Still causes game crash with your + biome mod

Exopandora commented 1 year ago

As expected, shoulder surfing works just fine with biomes'o'plenty (the mod that causes the crash according to the logs you provided).

SSR+BOP

Nevertheless i got working development workspace now.

ghost commented 1 year ago

Now add SereneSeasons-1.7.10-1.2.18, and I don't use BoP world preset tho

ghost commented 1 year ago

Hmm, actually it's something else more, I'll investigate

ghost commented 1 year ago

So actually it's ShoulderSurfing-1.7.10-2.2.3 + SereneSeasons-1.7.10-1.2.18 + falsetweaks-mc1.7.10-2.0.0-beta0003 and it's libs(falsepatternlib-mc1.7.10-0.10.13 + 00gasstation-mc1.7.10-0.3.5) If I delete one of them - it's just works, if not - will get this Mixin error Do you have Discord?

Exopandora commented 1 year ago

After further investigation it looks like gasstation messes up classloading in a real bad way and there is nothing i can do about it. If i am correct, the game should also crash with other coremods (not just shoulder surfing). Though this may be influenced by the order in which the mods load.

ghost commented 1 year ago

So gasstation breaks your mod?

Exopandora commented 1 year ago

I think so. And in theory it should also break other (core-)mods.

ghost commented 1 year ago

Can you make detail report to them?

Exopandora commented 1 year ago

Well, its complicated and i do not understand it fully yet

ghost commented 1 year ago

Report at least something since they support 1.7.10 now

Exopandora commented 1 year ago

Finally found the issue. It was a classloading issue that only happens with this specific setup and two different mixin versions. While i am at it i will also update the 1.7.10 version to the latest featureset (2.2.13). You can expect an update in the coming week.

Exopandora commented 1 year ago

A new version can now be found on curseforge

ghost commented 1 year ago

Thicc, do you have discord?

Exopandora commented 1 year ago

why?

ghost commented 1 year ago

To ask about modding

Exopandora commented 1 year ago

If you post yours, i will add you. In advance: i will not develop mods for you.

ghost commented 1 year ago

Sego#3180