Exopy / exopy_hqc_legacy

Transition package to smooth transition from HQCMeas to Exopy.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

dc_tasks: set current, function, output #35

Closed leghtas closed 7 years ago

leghtas commented 7 years ago

Here are a few useful tasks for DC sources. It is tedious to change the function mode, but that is the desired result to make the user is aware of the consequences: the source will suddenly turn off. A question I had was: should the protection from changing the output and function be at the level of the driver or at the level of the task. As of now it is at the level of the driver, which means that you can never change output with this driver without setting the source to 0. The good thing is that future tasks will have to comply by this. The bad thing is that future drivers may not implement these conditions... I am open to comments.

MatthieuDartiailh commented 7 years ago

I missed it but you also broke a test...

MatthieuDartiailh commented 7 years ago

I will merge as is but it may be a good idea (and exercise) to add tests in the future for the new tasks.