search

Exopy / exopy_hqc_legacy

Transition package to smooth transition from HQCMeas to Exopy.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Bug fixing on Python 3.8 #69

Closed rassouly closed 3 years ago

rassouly commented 3 years ago

A couple random bug fixes and a migration from Unicode to Str

rassouly commented 3 years ago

The errors on the Python 3.6 version are exactly the ones I fixed by migrating all the Unicodefields to Str. Since the errors are only in the conversion code which is completely unused by now, it might be ok to merge anyway.

EDIT: I think the errors come from exopy_pulses which I still have not migrated to Str

MatthieuDartiailh commented 3 years ago

I agree that the conversion code has no real value anymore. I would be fine with it being removed from the repo (perhaps in its own PR). It would be worth bumping the tested version of Python to 3.6, 3.7 and 3.8 also.

MatthieuDartiailh commented 3 years ago

I think we can drop 3.5 from the test matrix (I believe I already did so for exopy itself). Also when you corrected the indentation, did you check the line length (<89) ?

rassouly commented 3 years ago

I've bumped the minimum version to 3.6 and I've checked the line length

MatthieuDartiailh commented 3 years ago

Could you skip the tests in conversion to avoid the apparent bad CIs ? Once this is done I will merge. Would you have time for a PR removing the conversion code ?

rassouly commented 3 years ago

I've skipped the failing tests but Travis doesn't seem to be able to install exopy on Python 3.7 because apparently exopy_pulses requires a lower version of python.

rassouly commented 3 years ago

I'm also preparing a PR to remove all the conversion code. I'll send it once the CI changes are merged

MatthieuDartiailh commented 3 years ago

I will try to fix the builds later this week... I forgot how it worked and made a bigger mess... Should be done Wednesday night.

rassouly commented 3 years ago

Thank you, have a nice week

MatthieuDartiailh commented 3 years ago

Ok the CIs of every repos are now fixed so I am going to merge this now.