search

Exopy / exopy_hqc_legacy

Transition package to smooth transition from HQCMeas to Exopy.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Remove all uses of ask_for_values #71

Closed rassouly closed 3 years ago

rassouly commented 4 years ago

ask_for_values has been deprecated by the pyvisa library so this patch updates all uses of ask to query.

Currently tested:

rassouly commented 4 years ago

I've tested this patch for most of the instruments I have access to (with the exceptions of the AWG since the current drivers are not on master), and it seems to work

MatthieuDartiailh commented 4 years ago

@rassouly can you list which driver you did not test ? @galactikvoyager could somebody on your side check the remaining drivers ? I am not comfortable merging without some sanity check on your side first.

rassouly commented 4 years ago

I did not test any multimeter (Agilent or Keysight), the Cryomagnetics and Oxford current sources, the R&S VNA and ZVA and the SR lock-in. Some of the drivers in the folder seem to not be registered in the manifest such as the LeCroy oscilloscope (we have one but we use it manually), the agilent PSA (we've just bought one, the driver looks a bit weird but I could try it). As I said previously, I didn't bother testing the AWGs since the drivers on this branch are quite outdated.

MatthieuDartiailh commented 4 years ago

Thanks @rassouly, I guess @leghtas should have a look then for the R&S instruments.

rassouly commented 3 years ago

The new version of Pyvisa has already dropped support for ask_for_valuesand nobody in Paris has commented in 2 months. Currently a new installation of exopy is not functional because of this change. Can you merge this now? If Paris has issues, they can fix it later.

rassouly commented 3 years ago

The build error is simply a timeout from the conda website when travis was trying to install exopy from conda.

MatthieuDartiailh commented 3 years ago

BTW can you add a releasenote about this change as part of #72 ?