search

Exopy / exopy_hqc_legacy

Transition package to smooth transition from HQCMeas to Exopy.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Fix the SetDCOutput task #75

Closed rassouly closed 3 years ago

rassouly commented 3 years ago

The task code was not matching the view code and was thus unusable.

MatthieuDartiailh commented 3 years ago

I agree the task is broken (changing the state of the output is generally dangerous and not something I implemented at first). However since nobody can use we could make if nicer by having the formula evaluate to a boolean maybe (like it is for RF sources I believe). Also with the current state of the patch the task is not loopable (but that may be what you want).

rassouly commented 3 years ago

I agree that changing the state of the output can be quite dangerous for our type of experiments but I like the combo box of this task better than the dynamic text input of the RF version (no need for quotes around "On"/"Off" or numbers that look out of place). The combo box doesn't lend itself to a loopable input so I left it that way. This task is best left as some form of initialization task where the input is static. We use it to make measurement more self contained and reproducible (and reduce the number of times where we spend an hour chasing a problem caused by a source being switched off).

MatthieuDartiailh commented 3 years ago

If you remove the loopability, you need to update the metadata in the declaration.

MatthieuDartiailh commented 3 years ago

Since I doubt this was ever used, I am fine with the changes. Thanks @rassouly