Exopy / i3py

[WIP] Instrument interfacing in Python
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Drivers: structure of the package and drivers for DC power source #9

Open MatthieuDartiailh opened 6 years ago

MatthieuDartiailh commented 6 years ago

So far only the "standard" for DC power source is implemented and used for:

@Exopy/owners I would appreciate if you can give this a look, hopefully the documentation (http://i3py.readthedocs.io/en/latest/?badge=latest) should be enough to understand the magic happening behind the scene. I would appreciate to get as much feedback as possible since this is the future for drivers. I will work on implementing a generic task giving access to any feature/action of such a driver which will reduce the burden of developing super specific task for just setting a parameter.

codecov[bot] commented 6 years ago

Codecov Report

Merging #9 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          28       28           
  Lines        2282     2282           
=======================================
  Hits         2252     2252           
  Misses         30       30
lcontami commented 6 years ago

A few quick documentation questions: section 1.5 (subsystems) "By default, a subsystem is a subclass of || " ?

section 4.1.1 " first class of the mro" ?

MatthieuDartiailh commented 6 years ago

Just pushed a documentation fix. The quick answer is |SubSystem| for the first and mro: Method resolution order for the second (hence we use the left most class in the class declaration that defines a particular subsystem/channel).

MatthieuDartiailh commented 6 years ago

The bilt is complete and tested (just like the others, as far as the test scripts do their job at least). You need to look at the base class of the rack which declares the modules it can drive.

bilderbuchi commented 6 years ago

FYI there's a pytest notice in the CI log:

pytest-catchlog plugin has been merged into the core, please remove it from your requirements.

MatthieuDartiailh commented 6 years ago

Thanks @bilderbuchi I fixed that in other repos but I forgot this one.

MatthieuDartiailh commented 6 years ago

@lcontami @galactikvoyager feel free to merge when you have no more questions.