search

ExpDev07 / laravel-cashier-stripe-connect

💲 Adds Stripe Connect functionality to Laravel's main billing package, Cashier. Simply works as a drop-in on top of Cashier, with no extra configuration.
https://github.com/ExpDev07/laravel-cashier-stripe-connect
MIT License
61 stars 27 forks source link

PHP 8 order parameter fix and the arrival_date payout option is removed #15

Open asanovr opened 3 years ago

asanovr commented 3 years ago
  1. The $amount parameter for reverse transfer can be null by default and is not required #10
  2. The arrival_date parameter is not needed to create a payout https://stripe.com/docs/api/payouts/create
  3. Missing brace is fixed
asanovr commented 3 years ago

@ExpDev07

MariusSpring commented 3 years ago

Hey! Wouldn't this be a breaking change? To insert a new parameter between other params? @asanovr

asanovr commented 3 years ago

@MariusTechweb Hi!, Yeah! I removed only one argument in the payoutStripeAccount method, it doesn't work anyway, I tested it a few weeks ago

oleg-kolzhanov commented 2 years ago

Hey! Wouldn't this be a breaking change? To insert a new parameter between other params? @asanovr

Agree.