search

ExpHP / rsp2

phonons in rust
Apache License 2.0
2 stars 1 forks source link

sloppy naming of eigenvalues/frequencies in code #60

Closed ExpHP closed 5 years ago

ExpHP commented 6 years ago

Variables containing frequencies are often called "eigenvalues", which is misleading.

I could rename them, but knowing me I'd soon just make the same mistake again. I'd prefer to add a Frequency newtype.

ExpHP commented 5 years ago

I think this is resolved as of 4a507a25aa6c9aa05d04b24bcc9539f7619fc222, where many rust variables were renamed. It turns out that conversion from eigenvalue to frequency happens right at the border between rust and python, so virtually all rust code deals with frequencies and all python code deals with eigenvalue.