search

ExpHP / rsp2

phonons in rust
Apache License 2.0
2 stars 1 forks source link

dftbplus is accidentally required #87

Closed ExpHP closed 5 years ago

ExpHP commented 5 years ago

This is due to !!WORKSPACE-MEMBERS-AS-PATH-DEPS expanding to include all workspace crates, which includes rsp2-dftbplus.

A simple solution is to get rid of that macro and just have all workspace deps explicitly appear in crates.d/rsp2.Cargo.toml.

ExpHP commented 5 years ago

wtf, travis just failed with requiring dftb+ even though that job shouldn't require it!

https://travis-ci.com/ExpHP/rsp2/jobs/199511852

I guess this is because the travis test uses cargo build --all? Bleeehhhhhhhhh. :/

ExpHP commented 5 years ago

Fixed Travis somewhat awkwardly by giving rsp2-dftbplus a default-disabled feature that enables basically the whole crate.