search

ExpTechTW / TREM-tauri

Taiwan Real-time Earthquake Monitoring（臺灣即時地震監測）
https://exptech.com.tw/trem
GNU Affero General Public License v3.0
149 stars 14 forks source link

fix: eew intensity site effect #75

Closed Fonger closed 6 months ago

Fonger commented 7 months ago

Hi,

I've noticed a potential issue in the code where the regional site effect parameters might not be incorporated into the PGA formula. This is fixed by 8a9f0adb70575b115b271fc243c94bc5c7097b0e

Currently, the parameter seems to default to 1.751.

If this observation is correct, it could potentially lead to less precise seismic response calculations for various regions.

I believe integrating specific site effect parameters for each area could enhance the accuracy of our earthquake impact assessments.

https://github.com/ExpTechTW/TREM-tauri/blob/8a9f0adb70575b115b271fc243c94bc5c7097b0e/src/scripts/helper/utils.ts#L200-L208

There's also a small optimization: 009c6667e1d10ebbdf39ea32b94f7b2ad0df9c7f We can use the intensity map to get local intensity without re-calculation.

Fonger commented 6 months ago

@whes1015 Thanks for the review.

I see you enable auto-merge but it seems I need your approval to run the build workflow

image