search

ExpandingMan / Arrow.jl

DEPRECATED in favor of [JuliaData/Arrow.jl](https://github.com/JuliaData/Arrow.jl)
Other
56 stars 9 forks source link

pointerpocalypse #3

Closed ExpandingMan closed 6 years ago

ExpandingMan commented 6 years ago

I've been doing some research, and as it turns out it seems just as efficient to carry around the Vector{UInt8} array object for the data buffer itself as it is to carry around a pointer to it. Views will still have to be made with pointers and unsafe_wrap (ideally should put this into a proper SubArray object) because of the need to reinterpret the underlying data.

This change should be made as it simplifies things. Will require a fairly big overhaul.

ExpandingMan commented 6 years ago

All done! Most unsafe methods remain in the package but are not used by default (except in presence of WeakRefStrings). Note that there will be no way of creating safe views until 0.7 (will require ability to reinterpret a view).