fix to copy and cleanup

ExpandingMan / Arrow.jl

DEPRECATED in favor of [JuliaData/Arrow.jl](https://github.com/JuliaData/Arrow.jl)

Other

56 stars 9 forks source link

fix to copy and cleanup #36

Closed ExpandingMan closed 5 years ago

ExpandingMan commented 5 years ago

This fixes #35 and cleans up various things:

Drop support for pre-1.0.
Explicitly extend functions from Base rather than using import.
Put exports in a sane place rather than sprinkling them unpredictably throughout the whole damn package.
Added a Project.toml and removed REQUIRE.

Once this gets merged, I will tag it as 0.3.0.

ExpandingMan commented 5 years ago

Going to merge this tomorrow morning if there are no objections.

davidanthoff commented 5 years ago

I don't think REQUIRE files can be removed yet, if you want to use the normal METADATA.jl/attobot infrastructure.

IMO one should actually not add Project.toml files, because what ends happening is that CI tests uses that, but then the actual deployment via METADATA relies on the REQUIRE file, and so CI will not find errors in the REQUIRE file. Much safer in my mind to just have a REQUIRE file until the infrastructure is properly migrated (there really isn't any benefit of having a Project.toml, as far as I can tell).

ExpandingMan commented 5 years ago

I will restore the REQUIRE file, but since 1.0 when I'm working I usually only look in the Project.toml files so I don't want to get rid of it. I have seen a good number of other packages with these in the repo by now, for example here.

davidanthoff commented 5 years ago

I think the danger with that is that folks look at the Project.toml, update that and forget about the REQUIRE file. CI won't catch that, but then they tag a release and everything breaks for everyone... In my mind it is really crucially to have CI test the thing that actually determines what end-users see, and that doesn't happen when there is a Project.toml around.

Having said that, if you are super careful and never forget to update REQUIRE, nothing bad should happen. But then, that could be said about all testing, right ;)