search

ExpediaGroup / adaptive-alerting

Anomaly detection for streaming time series, featuring automated model selection.
Apache License 2.0
202 stars 49 forks source link

Initial commit for detector runner #743

Closed pranavsundriyal closed 4 years ago

pranavsundriyal commented 4 years ago

@pranavsundriyal can you please add some more description about this PR. Right now I am not able to understand the use case for all these changes. What is the problem statement and why we are doing these changes and how it will help?

@karanshah03 can you review this as well

codecov[bot] commented 4 years ago

Codecov Report

Merging #743 into master will decrease coverage by 0.87%. The diff coverage is 38.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   87.67%   86.80%   -0.88%     
==========================================
  Files         166      173       +7     
  Lines        3286     3508     +222     
  Branches      231      249      +18     
==========================================
+ Hits         2881     3045     +164     
- Misses        327      379      +52     
- Partials       78       84       +6
Impacted Files Coverage Δ
...alerting/kafka/detectorrunner/DetectorManager.java 15.38% <15.38%> (ø)
...ealerting/kafka/detectorrunner/SimpleDetector.java 23.80% <23.80%> (ø)
...ealerting/kafka/detectorrunner/MetricConsumer.java 41.50% <41.50%> (ø)
...expedia/adaptivealerting/kafka/DetectorRunner.java 50.00% <50.00%> (ø)
...alerting/kafka/detectorrunner/AnomalyProducer.java 77.77% <77.77%> (ø)
...a/adaptivealerting/anomdetect/DetectorManager.java 84.54% <0.00%> (-0.88%) :arrow_down:
...vealerting/modelservice/util/RequestValidator.java 100.00% <0.00%> (ø)
...rting/anomdetect/source/DefaultDetectorSource.java 100.00% <0.00%> (ø)
...ing/modelservice/web/LegacyDetectorController.java 100.00% <0.00%> (ø)
...ervice/repo/impl/LegacyDetectorRepositoryImpl.java 88.74% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 019e322...0ca1eca. Read the comment docs.

pranavsundriyal commented 4 years ago

Creating this springboot repo as a way for other team to add their on algos/detector and run them on existing kafka data and write back anomalies to kafka queue. Eventually this app will not be in the adaptive-alerting repo and rather be forked out in the expedia internal by other teams for use or it can be probably broken down into a lib which can be used by any team that has a algo they want to test. @williewheeler would you like to add more to the description.