search

ExpediaGroup / adaptive-alerting

Anomaly detection for streaming time series, featuring automated model selection.
Apache License 2.0
204 stars 49 forks source link

Enhancement/detector manager #749

Closed karanshah03 closed 4 years ago

karanshah03 commented 4 years ago

A given detector can be attached to multiple mappings and we would want to update detectorLastAccessedTime only once for a given detector UUID. So using a HashSet where we can maintain a set of unique UUIDs (order doesn't matter here) whose last accessed time needs to be updated instead of a queue which will have duplicate UUIDs as well. This means less number of calls to elastic search to update the detector's last accessed time field.

codecov[bot] commented 4 years ago

Codecov Report

Merging #749 into master will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   88.26%   88.33%   +0.06%     
==========================================
  Files         168      168              
  Lines        3417     3420       +3     
  Branches      238      237       -1     
==========================================
+ Hits         3016     3021       +5     
+ Misses        320      319       -1     
+ Partials       81       80       -1
Impacted Files Coverage Δ
...a/adaptivealerting/anomdetect/DetectorManager.java 86.72% <100.00%> (+2.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3978cf7...0995a46. Read the comment docs.