search

ExpediaGroup / adaptive-alerting

Anomaly detection for streaming time series, featuring automated model selection.
Apache License 2.0
202 stars 49 forks source link

add finish to detectormanager span #765

Closed dinilatgit closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #765 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #765   +/-   ##
=======================================
  Coverage   88.65%   88.66%           
=======================================
  Files         171      171           
  Lines        3544     3545    +1     
  Branches      245      245           
=======================================
+ Hits         3142     3143    +1     
  Misses        320      320           
  Partials       82       82
Impacted Files Coverage Δ
...a/adaptivealerting/kafka/KafkaDetectorManager.java 89.10% <100.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21a7742...7ff4c5a. Read the comment docs.

dinilatgit commented 4 years ago

The detector manager span is only to add tags to the complete trace which is created and managed by the library. The span is not designed to calculate trace in detector manager, that is done by the library interceptor class itself.

https://github.com/opentracing-contrib/java-kafka-client/issues/77 has been logged to know if there is a way to provide tags to the library functions. Detector Manager span is a work around.