Update Patrick's PR with IRSA and keep policies in the module

ExpediaGroup / apiary-federation

Terraform scripts for deploying Apiary Data Lake federation

https://github.com/ExpediaGroup/apiary

Apache License 2.0

5 stars 10 forks source link

Update Patrick's PR with IRSA and keep policies in the module #103

Closed barnharts4 closed 2 years ago

barnharts4 commented 2 years ago

overall looks good, just need to fix annotations.

Done. Can you please re-review?

barnharts4 commented 2 years ago

I test this again today by using k8s dashboard shell to shell into the WD pod in egdp-dev and was able to run aws glue list-databases without any issue. Also aws sts get-caller-identity showed the right IAM role. So I am assuming this is correct.