ExpediaGroup / apiary-federation

Terraform scripts for deploying Apiary Data Lake federation
https://github.com/ExpediaGroup/apiary
Apache License 2.0
5 stars 10 forks source link

Datadog_metrics_enabled - added the metrics annotations for waggledance #124

Closed DhrubajyotiSadhu closed 1 year ago

DhrubajyotiSadhu commented 1 year ago

:pencil: Description

:link: Related Issues

javsanbel2 commented 1 year ago

The addition of Datadog labels should be optional and only if Datadog integration is active, what do you think?

javsanbel2 commented 1 year ago

Also the kubernetes namespace and the metric port should be coded with variables because is due to change between deployments.

DhrubajyotiSadhu commented 1 year ago

@javsanbel2 The namespace specified here \"namespace\": \"waggledance\" is not referring to the kubernetes namespace. What it actually does is append waggledance_<metrics_name> in front of each metric.

abhimanyugupta07 commented 1 year ago

Yes. those are good points @javsanbel2

javsanbel2 commented 1 year ago

You are right, in that case let's add 1 variable only for the metric port 👍