search

ExpediaGroup / graphql-kotlin

Libraries for running GraphQL in Kotlin
https://opensource.expediagroup.com/graphql-kotlin/
Apache License 2.0
1.74k stars 351 forks source link

Upgrade to ktor version 3 #2045

Closed ronjunevaldoz closed 5 days ago

ronjunevaldoz commented 1 month ago

:pencil: Description

Upgrade ktor to version 3.x.x

:link: Related Issues

https://github.com/ExpediaGroup/graphql-kotlin/issues/2037

ronjunevaldoz commented 1 month ago

found some error that requires Kotlin version to be at-least 2.0.0-RC1.

Since there was an existing TODO, I let someone upgrade it first then. I'll bump to ktor stable versions instead (v3.0.0)

TODO kotlin 1.9 upgrade: fix GraphQLTestUtils and GenerateKotlinxClientIT
Your current Kotlin version is 1.9.24, while kotlinx.serialization core runtime 1.7.2 requires at least Kotlin 2.0.0-RC1. Please update your Kotlin compiler and IDE plugin.
daniel-humla commented 2 weeks ago

@ronjunevaldoz Kotlin is now bumped to version 2 so this could be picked up again

ronjunevaldoz commented 1 week ago

@ronjunevaldoz Kotlin is now bumped to version 2 so this could be picked up again

checking on it

samuelAndalon commented 5 days ago

closing in favor of the other ktor update PR