ExpediaGroup / waggle-dance

Hive federation service. Enables disparate tables to be concurrently accessed across multiple Hive deployments.
Apache License 2.0
271 stars 75 forks source link

Improve validation of ACCESS_CONTROL_TYPE settings for the FederatedMetastore #167

Open patduin opened 5 years ago

patduin commented 5 years ago

From the docs:

Primary metastores can configure access-control-type to have any of the described access-control-types whereas federated metastores may only be configured to READ_ONLY and READ_AND_WRITE_ON_DATABASE_WHITELIST.

The validation for these settings should be done on the configuration object com.hotels.bdp.waggledance.api.model.FederatedMetaStore. Instead currently the settings are validated in the com.hotels.bdp.waggledance.server.security.AccessControlHandlerFactory which isn't launched until a request made. Ideally WD shouldn't start if the configuration is wrong.

Acceptance Criteria:

massdosage commented 5 years ago

We should take #153 and #154 into account while working on this. It might be useful to just fix this now but bear in mind it might no longer be needed (or will need to be implemented differently) if/when those tickets are worked on.

massdosage commented 4 years ago

@patduin is this worth keeping open?

patduin commented 4 years ago

Would be nice to fix, but yeah time...