search

ExpediaGroup / waggle-dance

Hive federation service. Enables disparate tables to be concurrently accessed across multiple Hive deployments.
Apache License 2.0
274 stars 76 forks source link

Support kerberos and delegation-token #266

Closed zzzzming95 closed 1 year ago

zzzzming95 commented 1 year ago

:pencil: Description

The authentication of our environment is all based on kerberos. I can see the kerberos patch in : https://github.com/ExpediaGroup/waggle-dance/commit/a4ea6950eb755ca279e405b3730a6f9a0a28f1dc

But the earlier patch for kerberos has some flaws, such it not support delegation-token auth , using the duplicate HadoopThriftAuthBridge.Server. We fix it and now it work well in our env.

:link: Related Issues

https://github.com/ExpediaGroup/waggle-dance/issues/264

zzzzming95 commented 1 year ago

@abhimanyugupta07 @javsanbel2 cc

patduin commented 1 year ago

@abhimanyugupta07 @javsanbel2 cc

Thanks for the contribution! We'll try to have some eyes on this asap. Just a quick FYI we can run our tests but we don't have a Kerberos environment ourselves so those specific changes we'll have to rely on your tests.

zzzzming95 commented 1 year ago

@abhimanyugupta07 @javsanbel2 cc

Thanks for the contribution! We'll try to have some eyes on this asap. Just a quick FYI we can run our tests but we don't have a Kerberos environment ourselves so those specific changes we'll have to rely on your tests.

Thank you for your reply. I have run all the unit tests locally and they passed. We will submit patches for other improvements to this feature internally later.

zzzzming95 commented 1 year ago

@patduin @abhimanyugupta07

All comments have been corrected, please take a look again . thanks ~

patduin commented 1 year ago

@abhimanyugupta07 have a look please if ok, we can merge this.

or @massdosage :) thanks for reviewing

zzzzming95 commented 1 year ago

In response to the recommendations are adjusted, thanks again . @massdosage

patduin commented 1 year ago

Thank you @zzzzming95 This looks good! I think @massdosage still has some open comments, please have a look. @massdosage @abhimanyugupta07 if you both are happy please approve?

zzzzming95 commented 1 year ago

Thank you @zzzzming95 This looks good! I think @massdosage still has some open comments, please have a look. @massdosage @abhimanyugupta07 if you both are happy please approve?

all would be fix~

massdosage commented 1 year ago

LGTM, thanks for the contribution @zzzzming95