search

ExpediaGroup / waggle-dance

Hive federation service. Enables disparate tables to be concurrently accessed across multiple Hive deployments.
Apache License 2.0
268 stars 75 forks source link

Hive 3.x backport readonly and ratelimit feature #321

Closed flaming-archer closed 3 months ago

flaming-archer commented 3 months ago

:pencil: Description

Make sure that the 3.x branch and the main branch are not too far apart.

:link: Related Issues

https://github.com/ExpediaGroup/waggle-dance/discussions/319

flaming-archer commented 3 months ago

@jmnunezizu @patduin pls take a look at it. The audit log, HMSHandler.getThreadLocalIpAddress was removed because of this method in hive 3.x is not public. It's not worth writing reflections for it alone.

flaming-archer commented 3 months ago

This failed test case should have nothing to do with submission:Error: Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8:deploy (injected-nexus-deploy) on project waggle-dance-rpm: Failed to deploy artifacts: Could not transfer artifact com.hotels:waggle-dance-boot:jar:exec:4.0.0-20240626.031244-2 from/to sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots): authentication failed for https://oss.sonatype.org/content/repositories/snapshots/com/hotels/waggle-dance-boot/4.0.0-SNAPSHOT/waggle-dance-boot-4.0.0-20240626.031244-2-exec.jar, status: 401 Unauthorized -> [Help 1]

flaming-archer commented 3 months ago

@jmnunezizu Could you pls review this and merge it.

jmnunezizu commented 3 months ago

@flaming-archer – thanks for porting the new features to the Hive 3.x branch!